Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed SDF pickle bug #4

Merged
merged 1 commit into from
Jan 31, 2023
Merged

Fixed SDF pickle bug #4

merged 1 commit into from
Jan 31, 2023

Conversation

chryswoods
Copy link
Contributor

If this is to fix a bug...

This pull request fixes issue #415 in the michellab/BioSimSpace repo

  • I confirm that I have merged the latest version of devel into this branch before issuing this pull request (e.g. by running git pull origin devel): [y]
  • I confirm that I have permission to release this code under the GPL3 license: [y]

@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods temporarily deployed to sire-build January 31, 2023 09:51 — with GitHub Actions Inactive
@chryswoods chryswoods mentioned this pull request Jan 31, 2023
Closed
lohedges
lohedges approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@lohedges lohedges left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah great, good catch. I assumed it was something simple with properties specific to the SDF format.

@chryswoods chryswoods merged commit 924c62a into devel Jan 31, 2023
@chryswoods chryswoods deleted the fix_sdf_pickle branch January 31, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lohedges lohedges lohedges approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@chryswoods @lohedges