Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #49 and closes #50.
For #49 we now add a small bias when performing the triclinic lattice reduction to avoid issues with numerical precision due to the fixed-width format of box lattice vectors and angles in molecular input files. I've added a test to confirm that the resulting box is stable, i.e. it no longer oscillates about two sets of angles. The box is stable regardless of the way in which the triclinic box is instantiated, i.e. from box vectors, or magnitudes and angles.
For #50 I've added an appropriately pinned
run_constrained
entry forrdkit
, so that a compatible version ofrdkit
will be installed alongside Sire, which currently isn't the case. This is currently entered directly in the conda recipe. It may be desirable to add this to a requirements file to be consistent with the other entries, or if we have other optional requirements that also need constraining. (That said, I'm not sure how the logic would be expressed.)devel
into this branch before issuing this pull request (e.g. by runninggit pull origin devel
): [y]