Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Flemish' language entry is overriding 'Dutch' language #81

Open
giorgio-zamparelli opened this issue Apr 13, 2018 · 3 comments
Open

'Flemish' language entry is overriding 'Dutch' language #81

giorgio-zamparelli opened this issue Apr 13, 2018 · 3 comments

Comments

@giorgio-zamparelli
Copy link

import countryData from 'country-data';
console.log(countryData.languages.nl.name); //outputs Flemish instead of Dutch

This is because the languages.csv file has the entries Dutch and Flemish with identical values

alpha2=nl
alpha3=nld
bibliographic=dut

I suggest removing the Flemish entry since Flemish it's considered not a language but rather an adjective/thesaurus to define Dutch dialects.

Dutch is the correct English word to define the Dutch language spoken in both The Netherlands and Belgium.

I can prepare a Pull Request with the Flemish entry removed from the languages.csv file.

giorgio-zamparelli added a commit to giorgio-zamparelli/country-data that referenced this issue Apr 13, 2018
@Sonatrix
Copy link

@giorgio-zamparelli
could you make a pull request to
https://github.com/Sonatrix/country-list
regarding this issue

@giorgio-zamparelli
Copy link
Author

Hi @Sonatrix! Has @evdb abandoned this repository permanently and country-data-list is the main fork under development?!

@Sonatrix
Copy link

Hi @giorgio-zamparelli ,
@evdb is not maintaining this library anymore, I created a fork of it and maintaining it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants