WIP - 274 file download name should be more appropriate #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaaikeB
force-pushed
the
274-file-download-name-should-be-more-appropriate
branch
from
86f45ab
to
098c0e5
Compare
MaaikeB
force-pushed
the
274-file-download-name-should-be-more-appropriate
branch
from
aa7ec41
to
0afee20
Compare
akariv
approved these changes
Apr 16, 2019
akariv
reviewed
Apr 16, 2019
MaaikeB
force-pushed
the
274-file-download-name-should-be-more-appropriate
branch
from
0afee20
to
d69149c
Compare
Instead of giving the downloaded file always the same name, the name is now taken from the parameter send in the query string.
MaaikeB
force-pushed
the
274-file-download-name-should-be-more-appropriate
branch
from
d69149c
to
6b95307
Compare
|
@akariv please review fixes |
akariv
approved these changes
Apr 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #274 .
Changes proposed in this pull request:
Dependent on OpenBudget/budgetkey-app-generic-item#107