Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename is_discount to is_negative #4

Open
hkdobrev opened this issue Nov 7, 2013 · 0 comments
Open

Rename is_discount to is_negative #4

hkdobrev opened this issue Nov 7, 2013 · 0 comments
Labels
breaking-change

Comments

@hkdobrev
Copy link
Contributor

hkdobrev commented Nov 7, 2013

Purchase items which have the is_discount flag are subtracted from the total price. However they could be used not only for discounts. For example fees, commissions and other similar charges could be subtracted as well.

I suggest renaming is_discount to is_negative so it is clear what it does and what it could be used for.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking-change
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@hkdobrev