Model_Purchase_Item::get_reference_paranoid() could break outside use of Jam_Behavior_Paranoid::filter()

[hkdobrev]

Model_Purchase_Item::get_reference_paranoid() looks like this:

/**
 * Get the reference even if it was deleted
 * @return Jam_Model
 */
public function get_reference_paranoid()
{
  Jam_Behavior_Paranoid::filter(Jam_Behavior_Paranoid::ALL);
  $reference = $this->get_insist('reference');
  Jam_Behavior_Paranoid::filter(Jam_Behavior_Paranoid::NORMAL);

  return $reference;
}

If you are using Jam_Behavior_Paranoid::filter() in an outside scope using Model_Purchase_Item::price() or Model_Purchase_Item::compute_price() it would not work as expected.

Imagine the following scenario:

Jam_Behavior_Paranoid::filter(Jam_Behavior_Paranoid::ALL);
foreach ($store_purchases as $store_purchase)
{
  $store_purchase->items[0]->price();
  ...
}
Jam_Behavior_Paranoid::filter(Jam_Behavior_Paranoid::NORMAL);

The price() call would actually set the paranoid filter back to normal even on the first iteration.

get_reference_paranoid() should use the old-school deleted() builder method.

[hkdobrev]

Fixed in 5ebcecc