Revert "Set brand purchase to added purchase item" #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phgeorgiev
reviewed
Jun 29, 2017
| $brand_purchase->add_or_update_item($new_item); | ||
| $new_item->brand_purchase = $brand_purchase; | ||
| $this | ||
| ->find_or_build_brand_purchase($brand) |
There was a problem hiding this comment.
Some wrong indentation here and the line below.
There was a problem hiding this comment.
@phgeorgiev I have reverted the changes. Would you make an issue to fix indentation?
There was a problem hiding this comment.
The Kohana modules should continue to follow Kohana coding style.
hkdobrev
approved these changes
Jun 29, 2017
|
What happened with this one? |
hkdobrev
deleted the
revert-35-brand-purchase-purchase-item-connection-on-add
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #35
Because the change introduces an unexpected behavior when product already exist in purchase, it adds additional purchase item which is a bug.