Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump for nodejs, electron, serialport and others #260

Merged
merged 7 commits into from Nov 1, 2022

Conversation

poWer4aiX
Copy link

Hi Peter, as promised I have tried to update to a more recent version of electron, as the one currently been used is no longer supported. Upgrade to V20 was not working (is also very fresh), but upgrading to V19. I have done all tests and build with nodejs 16.17.0

I have tested the code directly in VS Code under Ubuntu 22.04, as well with the generated appimage:

  • opening / closing / opening cycles from tray is working
  • UI is working
  • 3Dview is working
  • serial ports a found
  • change on serial port gets notified
  • connect to is working
  • moving my machine (Lead1010 with Blackbox) is running fine.
    There is one minor issue related to Chromium, which seems to be know (file open dialog hangs Chrome) but could be solved by changing the following setting:
$ gsettings set org.gnome.desktop.sound input-feedback-sounds false

Unfortunately I'm missing a VisualStudio so I cannot test the change in Window..

Christian Zahl added 5 commits September 22, 2022 19:27
+ drivelist to v11
+ serialport to v10
+ added script to start stand alone test
Rolling back to v19.0.17 and node.js v16 LTS as
electron v20 has issues to build serialport 10.4
@petervanderwalt
Copy link
Contributor

Thanks! Looking over the updated packages, may I ask you if you have moment to test:

  • avrgirl - used by the Firmware Flashing tool - just make sure you can flash Grbl succesfully?
  • drivelist - used by the Prepare USB for Interface under the Wizards and tools menu: See if a flashdrive pops up in the dropdown when you insert it, and goes away when removed

@poWer4aiX
Copy link
Author

Further tests made:

  • drivelist - used by the Prepare USB for Interface under the Wizards and tools menu: See if a flashdrive pops up in the dropdown when you insert it, and goes away when removed
    => Flashdrive pops up in the list of drives when I insert a flash-drive, and gets removed once I pull it out.

  • avrgirl - used by the Firmware Flashing tool - just make sure you can flash Grbl succesfully?
    I used the FW Flashing Tool to burn the FW into the Blackbox, by selecting "3Axes CNC/Laser: Dual-Y...", and seems to succeed:

[21:20:53] [ disconnect ] PORT INFO: Port closed
[21:20:54] [ Firmware Upgrade ] connected
[21:20:54] [ Firmware Upgrade ] reset complete.
[21:20:54] [ Firmware Upgrade ] flashing, please wait...
[21:21:16] [ Firmware Upgrade ]  flash complete.

@petervanderwalt
Copy link
Contributor

Thanks! Merging! (:

@petervanderwalt petervanderwalt merged commit be4e06a into OpenBuilds:master Nov 1, 2022
@petervanderwalt
Copy link
Contributor

petervanderwalt commented Nov 1, 2022

Yeah we'll have to stay on 14 for a little longer, Drivelist need >14 and <16

$ npm install
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'drivelist@11.0.2',
npm WARN EBADENGINE required: { node: '>=14 < 16' },
npm WARN EBADENGINE current: { node: 'v18.12.0', npm: '8.19.2' }
npm WARN EBADENGINE }

matko01 pushed a commit to matko01/OpenBuilds-CONTROL that referenced this pull request Nov 2, 2022
Version bump for nodejs, electron, serialport and others

Signed-off-by: Mato <matko01@users.noreply.github.com>
@poWer4aiX
Copy link
Author

Oh, seems that I missed this :-( Well there is a pending PR to support <v19 , so let's hope they will merge it soon. As v14 will run out of security updates maintenance in approx. 5 months, an upgrade seems to be required...

@petervanderwalt
Copy link
Contributor

For sure! Soon soon! (:
Glad its the only one still holding us back - rest looks good - thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants