New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Version bump for nodejs, electron, serialport and others #260
Conversation
+ drivelist to v11 + serialport to v10 + added script to start stand alone test
Rolling back to v19.0.17 and node.js v16 LTS as electron v20 has issues to build serialport 10.4
Thanks! Looking over the updated packages, may I ask you if you have moment to test:
|
Further tests made:
|
Thanks! Merging! (: |
Yeah we'll have to stay on 14 for a little longer, Drivelist need >14 and <16 $ npm install |
Version bump for nodejs, electron, serialport and others Signed-off-by: Mato <matko01@users.noreply.github.com>
Oh, seems that I missed this :-( Well there is a pending PR to support <v19 , so let's hope they will merge it soon. As v14 will run out of security updates maintenance in approx. 5 months, an upgrade seems to be required... |
For sure! Soon soon! (: |
Hi Peter, as promised I have tried to update to a more recent version of electron, as the one currently been used is no longer supported. Upgrade to V20 was not working (is also very fresh), but upgrading to V19. I have done all tests and build with nodejs 16.17.0
I have tested the code directly in VS Code under Ubuntu 22.04, as well with the generated appimage:
There is one minor issue related to Chromium, which seems to be know (file open dialog hangs Chrome) but could be solved by changing the following setting:
Unfortunately I'm missing a VisualStudio so I cannot test the change in Window..