Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add newlines to script runner logs #190

Merged
merged 1 commit into from Oct 5, 2022
Merged

Add newlines to script runner logs #190

merged 1 commit into from Oct 5, 2022

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Oct 5, 2022

closes #180

@jmthomas jmthomas requested a review from ryanmelt October 5, 2022 14:16
@codecov
Copy link

codecov bot commented Oct 5, 2022

Codecov Report

Base: 73.79% // Head: 73.79% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (bbf6176) compared to base (51036b9).
Patch coverage: 71.42% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   73.79%   73.79%           
=======================================
  Files         413      413           
  Lines       25551    25551           
  Branches      560      560           
=======================================
+ Hits        18855    18856    +1     
+ Misses       6611     6609    -2     
- Partials       85       86    +1     
Flag Coverage Δ
frontend 75.78% <ø> (-0.05%) ⬇️
ruby-api 43.91% <0.00%> (ø)
ruby-backend 78.18% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...nc3-script-runner-api/app/models/running_script.rb 19.50% <0.00%> (ø)
openc3/lib/openc3/version.rb 100.00% <100.00%> (ø)
...tlmserver/src/tools/CmdTlmServer/InterfacesTab.vue 47.05% <0.00%> (-5.89%) ⬇️
...smonitor/src/tools/LimitsMonitor/LimitsControl.vue 82.22% <0.00%> (+0.74%) ⬆️
openc3/lib/openc3/utilities/metric.rb 96.07% <0.00%> (+5.88%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jmthomas jmthomas merged commit e2f3a58 into master Oct 5, 2022
@jmthomas jmthomas deleted the script_log_newlines branch October 5, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Script Runner logs missing newlines
1 participant