Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Describe changed plugin.txt on install #423

Merged
merged 1 commit into from Jan 30, 2023
Merged

Describe changed plugin.txt on install #423

merged 1 commit into from Jan 30, 2023

Conversation

jmthomas
Copy link
Member

closes #414

@jmthomas
Copy link
Member Author

This is what it looks like when you modify the plugin.txt and then upgrade:
Screenshot 2023-01-30 at 7 37 57 AM

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Base: 74.67% // Head: 74.67% // No change to project coverage 👍

Coverage data is based on head (590423f) compared to base (32ad4f2).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #423   +/-   ##
=======================================
  Coverage   74.67%   74.67%           
=======================================
  Files         455      455           
  Lines       27671    27671           
  Branches      592      592           
=======================================
  Hits        20662    20662           
  Misses       6916     6916           
  Partials       93       93           
Flag Coverage Δ
ruby-api 50.24% <ø> (ø)
ruby-backend 78.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@ryanmelt ryanmelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice. I nominate you for chief of developer experience.

@jmthomas jmthomas merged commit 541314d into main Jan 30, 2023
@jmthomas jmthomas deleted the plugin_upgrade branch January 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plugin upgrade existing vs new plugin.txt
2 participants