Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade public js/css automatically #472

Merged
merged 7 commits into from Feb 10, 2023
Merged

Upgrade public js/css automatically #472

merged 7 commits into from Feb 10, 2023

Conversation

jmthomas
Copy link
Member

@jmthomas jmthomas commented Feb 9, 2023

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2023

Codecov Report

Base: 74.44% // Head: 74.53% // Increases project coverage by +0.08% 🎉

Coverage data is based on head (b2e47d6) compared to base (bab657a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #472      +/-   ##
==========================================
+ Coverage   74.44%   74.53%   +0.08%     
==========================================
  Files         458      458              
  Lines       27971    27988      +17     
  Branches      593      594       +1     
==========================================
+ Hits        20824    20860      +36     
+ Misses       7053     7034      -19     
  Partials       94       94              
Flag Coverage Δ
frontend 76.23% <ø> (+0.50%) ⬆️
ruby-api 50.08% <ø> (ø)
ruby-backend 78.52% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/utilities/authorization.rb 73.33% <0.00%> (-11.29%) ⬇️
...tsmonitor/src/tools/LimitsMonitor/LimitsEvents.vue 77.77% <0.00%> (-5.56%) ⬇️
openc3/lib/openc3/script/storage.rb 14.45% <0.00%> (-0.18%) ⬇️
openc3/lib/openc3/models/cvt_model.rb 100.00% <0.00%> (ø)
...ptrunner/src/tools/ScriptRunner/RunningScripts.vue 21.56% <0.00%> (ø)
...riptrunner/src/tools/ScriptRunner/ScriptRunner.vue 73.77% <0.00%> (+0.03%) ⬆️
...plorer/src/tools/BucketExplorer/BucketExplorer.vue 76.92% <0.00%> (+5.22%) ⬆️
...src/tools/ScriptRunner/Dialogs/OverridesDialog.vue 100.00% <0.00%> (+100.00%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

"sass": "1.32.13",
"sass-loader": "13.2.0",
"serve": "14.2.0",
"vue-loader": "15.9.8",
"vue-template-compiler": "2.7.14",
"webpack": "5.75.0",
"webpack-cli": "4.10.0",
"webpack-cli": "5.0.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaking change is that it now only works with webpack 5 which we already use

"single-spa": "5.9.4",
"vue": "2.7.14",
"vue-router": "3.5.4",
"vuetify": "2.6.14"
"vuetify": "2.6.14",
"vuex": "3.6.2"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added regenerator-runtime and vuex so I can automatically upgrade them

check_container_version(client, containers, 'traefik')
check_minio(client, containers)
check_container_version(client, containers, 'redis')
base_pkgs = %w(regenerator-runtime single-spa vue vue-router vuetify vuex)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are the packages that the script upgrades to the versions listed in openc3-tool-base/package.json. The only remaining javascript is the various systemjs stuff which rarely changes so that can be manual. I also don't try to upgrade the roboto fonts (not sure how actually).

@jmthomas
Copy link
Member Author

Not quite sure how to carry this over to Enterprise. Obviously there is tremendous overlap but the containers are different. I think we need a package_audit script in Enterprise can call this one and then add on the stuff that is different.

@jmthomas jmthomas merged commit ae47f89 into main Feb 10, 2023
@jmthomas jmthomas deleted the upgrades branch February 10, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants