New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade public js/css automatically #472
Conversation
Codecov ReportBase: 74.44% // Head: 74.53% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #472 +/- ##
==========================================
+ Coverage 74.44% 74.53% +0.08%
==========================================
Files 458 458
Lines 27971 27988 +17
Branches 593 594 +1
==========================================
+ Hits 20824 20860 +36
+ Misses 7053 7034 -19
Partials 94 94
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
"sass": "1.32.13", | ||
"sass-loader": "13.2.0", | ||
"serve": "14.2.0", | ||
"vue-loader": "15.9.8", | ||
"vue-template-compiler": "2.7.14", | ||
"webpack": "5.75.0", | ||
"webpack-cli": "4.10.0", | ||
"webpack-cli": "5.0.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Breaking change is that it now only works with webpack 5 which we already use
"single-spa": "5.9.4", | ||
"vue": "2.7.14", | ||
"vue-router": "3.5.4", | ||
"vuetify": "2.6.14" | ||
"vuetify": "2.6.14", | ||
"vuex": "3.6.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added regenerator-runtime and vuex so I can automatically upgrade them
check_container_version(client, containers, 'traefik') | ||
check_minio(client, containers) | ||
check_container_version(client, containers, 'redis') | ||
base_pkgs = %w(regenerator-runtime single-spa vue vue-router vuetify vuex) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the packages that the script upgrades to the versions listed in openc3-tool-base/package.json. The only remaining javascript is the various systemjs stuff which rarely changes so that can be manual. I also don't try to upgrade the roboto fonts (not sure how actually).
Not quite sure how to carry this over to Enterprise. Obviously there is tremendous overlap but the containers are different. I think we need a package_audit script in Enterprise can call this one and then add on the stuff that is different. |
No description provided.