Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bucket load #680

Merged
merged 3 commits into from May 23, 2023
Merged

Bucket load #680

merged 3 commits into from May 23, 2023

Conversation

ryanmelt
Copy link
Member

closes #669

@ryanmelt ryanmelt requested a review from jmthomas May 23, 2023 02:54
@codecov
Copy link

codecov bot commented May 23, 2023

Codecov Report

Patch coverage: 21.42% and project coverage change: -0.12 ⚠️

Comparison is base (761b0b7) 71.01% compared to head (7ab34cb) 70.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
- Coverage   71.01%   70.89%   -0.12%     
==========================================
  Files         469      470       +1     
  Lines       30004    30075      +71     
  Branches      816      816              
==========================================
+ Hits        21308    21323      +15     
- Misses       8611     8669      +58     
+ Partials       85       83       -2     
Flag Coverage Δ
frontend 58.61% <ø> (+0.19%) ⬆️
ruby-api 51.36% <25.00%> (+0.05%) ⬆️
ruby-backend 78.09% <20.00%> (-0.31%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
openc3/lib/openc3/utilities/bucket_utilities.rb 80.95% <20.00%> (-6.42%) ⬇️
...mos-script-runner-api/app/models/running_script.rb 18.96% <25.00%> (-0.80%) ⬇️

... and 3 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@jmthomas jmthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides the change around in files what has actually changed here?

@ryanmelt
Copy link
Member Author

You can do require 'openc3/utilities/bucket_require' and then require 'TARGET_NAME/procedures/whatever.rb' now

@jmthomas
Copy link
Member

You can do require 'openc3/utilities/bucket_require' and then require 'TARGET_NAME/procedures/whatever.rb' now

Any reason that shouldn't "just work" without the require?

@ryanmelt
Copy link
Member Author

Because I don't like always monkey patching a core ruby feature like require

@ryanmelt ryanmelt merged commit 875e1f7 into main May 23, 2023
12 checks passed
@ryanmelt ryanmelt deleted the bucket_load branch May 23, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Accessing File from outside the microservices folder with a microservice
2 participants