Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mux in favor of chi for URLParameter parsing #11

Conversation

alexlovelltroy
Copy link
Collaborator

Closes #10.

Needs testing from @davidallendj or @synackd before merge

@alexlovelltroy alexlovelltroy linked an issue Feb 2, 2024 that may be closed by this pull request
Copy link
Collaborator

@davidallendj davidallendj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Built and tested with multiple endpoints requiring URL parameters. It seems to work for me.

@synackd synackd self-requested a review February 2, 2024 22:43
Copy link
Contributor

@synackd synackd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Passing integration tests on OpenCHAMI/deployment-recipes#8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Router go-chi not handling URLs with parameters correctly
3 participants