-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve interpolation performance #358
Conversation
…p_coordinates for a substantial improvement of binning performance with momentum correction
Pull Request Test Coverage Report for Build 8286464547Details
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't quite clear to me why the map_coordinates is faster than scipy's interpolate method. But of course, those are seperate modules and seem to have very different implementations.
The parallelization is a nice addition. Everything seems good
For comparison of different methods see e. g. here: https://stackoverflow.com/questions/53857403/scipy-interpolation-speed-is-there-anything-faster-than-rectbivariatespline |
replace scipy.interpolate.RegularGridInterpolator by scipy.ndimage.map_coordinates for a substantial improvement
of binning performance with momentum correction
Closes #357