Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Jupyter lab version #359

Merged
merged 2 commits into from
Mar 19, 2024
Merged

Fix Jupyter lab version #359

merged 2 commits into from
Mar 19, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Mar 15, 2024

Fix Jupyter lab to version 3, for compatibility with the desy jhub

@coveralls
Copy link
Collaborator

coveralls commented Mar 15, 2024

Pull Request Test Coverage Report for Build 8350145260

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 3 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.05%) to 91.302%

Files with Coverage Reduction New Missed Lines %
sed/binning/numba_bin.py 3 87.74%
Totals Coverage Status
Change from base Build 8342113761: -0.05%
Covered Lines: 5994
Relevant Lines: 6565

💛 - Coveralls

@rettigl rettigl changed the title fix notebook and jupyterlab versions Fix Jupyter lab version Mar 15, 2024
@zain-sohail
Copy link
Member

Could you explain which compatibility it fixes? Do you mean that ipywidgets work then?

@rettigl
Copy link
Member Author

rettigl commented Mar 18, 2024

Yes, with the current ipywidgets version, there are no plots in jupyter lab <4, and on the desy jhub it's version 3.4. This pr fixes versions to a compatible setting.

Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this to be working

@rettigl rettigl merged commit 97f0b4d into main Mar 19, 2024
6 checks passed
@rettigl rettigl deleted the limit_jupyter_version branch March 19, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants