Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check for unused arguments and variables #373

Merged
merged 1 commit into from
Apr 4, 2024
Merged

Check for unused arguments and variables #373

merged 1 commit into from
Apr 4, 2024

Conversation

rettigl
Copy link
Member

@rettigl rettigl commented Mar 22, 2024

add linter options to check for unused arguments and variables, and add corresponding ignores

@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 8397020428

Details

  • 14 of 14 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 91.378%
Totals Coverage Status
Change from base Build 8391068208: 0.0%
Covered Lines: 6020
Relevant Lines: 6588
💛 - Coveralls

zain-sohail
zain-sohail approved these changes Apr 3, 2024
View reviewed changes
Copy link
Member

@zain-sohail zain-sohail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good addition.

@rettigl rettigl merged commit a5d4523 into main Apr 4, 2024
6 checks passed
@rettigl rettigl deleted the unused_arguments branch April 4, 2024 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zain-sohail zain-sohail zain-sohail approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rettigl @coveralls @zain-sohail