Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Revert "Merge pull request #102 from mariokonrad/upstream-tinyxml"
- Loading branch information
David Register
committed
Mar 5, 2014
1 parent
906e82f
commit b1f1630
Showing
14 changed files
with
13 additions
and
530 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
b1f1630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mario...
Nice patch, but not quite there yet.
ExternalProject_Add(extern_tinyxml
PREFIX "${CMAKE_CURRENT_BINARY_DIR}/tinyxml"
URL file://${CMAKE_CURRENT_SOURCE_DIR}/src_extern/tinyxml-2.6.2
SOURCE_DIR "${CMAKE_CURRENT_SOURCE_DIR}/src_extern/tinyxml-2.6.2"
-- Extern: TinyXML 2.6.2
CMake Error at ExternTinyXML.cmake:32 (add_dependencies):
add_dependencies Adding dependency to non-existent target: tinyxml
Call Stack (most recent call first):
CMakeLists.txt:548 (INCLUDE)
So, I have reverted the Pull request.
Dave
b1f1630
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Dave
It seems it is a problem with CMake (http://www.cmake.org/Bug/print_bug_page.php?bug_id=10395), but fixed in 2.8.4
On the homepage you stated Cmake version 2.8.3 as the (minimum) version required in order to build.
How would you like to proceed? Still interested in the patch and upgrade cmake or dismiss the patch?
Sorry, I was not aware of the 4 whitespace rule, did you define it final recently? I assume this also applies to CMakeLists.txt?
Bye,
Mario
edit:
Just found this: a compatiblity matrix for cmake: http://www.cmake.org/Wiki/CMake_Version_Compatibility_Matrix