Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MUI branch - segfaults opening dialog Options->Display->Advanced->Options #1184

Closed
transmitterdan opened this issue Dec 6, 2018 · 10 comments

Comments

@transmitterdan
Copy link
Collaborator

When trying to open the OpenGL Options dialog box i get a segfault. If backtrace would be helpful I can create it. If it is a known issue I can wait for a fix.

System: Ubuntu 18.04.1 LTS running in VirtualBox, Host system: Windows 10

@tai-fun
Copy link

tai-fun commented Dec 6, 2018 via email

@Hakansv
Copy link
Contributor

Hakansv commented Dec 6, 2018

I'm on Win10 and VS 2107 can't reproduce neither in Release nor Debug mode.
Probably not related but there is a file path change committed for this function yesterday.

@Hakansv
Copy link
Contributor

Hakansv commented Dec 6, 2018

For info I've built present MUI on a RPi 3b+. No problem to open the OpenGL Options dialog box.
My system for info:
raspex@raspberry:$ uname -a
Linux raspberry 4.14.76-v8+ #1 SMP PREEMPT Tue Oct 16 18:45:20 CEST 2018 aarch64 aarch64 aarch64 GNU/Linux
raspex@raspberry:
$ cat /etc/*release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=18.10
DISTRIB_CODENAME=cosmic
DISTRIB_DESCRIPTION="RaspEX - Ubuntu Cosmic Cuttlefish"
NAME="Ubuntu"
VERSION="18.10 (Cosmic Cuttlefish)"
ID=ubuntu
ID_LIKE=debian
PRETTY_NAME="Ubuntu 18.10"
VERSION_ID="18.10"
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
VERSION_CODENAME=cosmic
UBUNTU_CODENAME=cosmic

@bdbcat
Copy link
Member

bdbcat commented Dec 8, 2018

Thomas and/or Tdan...
@thomas:
The crash report you sent already was somehow scrambled and unusable.

I have made a fresh build for testing today:
https://www.dropbox.com/s/yck4fkw601y0pkg/opencpn_4.99.1207_setup.exe?dl=0

Please generate a crash again with 1207, if possible. Allow the report to be uploaded to my server.
A backtrace would be useful, if possible.
Thanks
Dave

@transmitterdan
Copy link
Collaborator Author

Dave,

My Windows build does not crash. But my Linux build will crash. Backtrace here:

backtrace.txt

@tai-fun
Copy link

tai-fun commented Dec 8, 2018 via email

@transmitterdan
Copy link
Collaborator Author

It is definitely easy to trigger the crash with OpenGL off. Since this MUI version seems not to have the software gl option it runs really slow with OpenGL off. I think a race condition is responsible for the crash. The options dialog takes a while to close as it does a lot of fiddling with chart data bases and the like. So for example if you try to shut down O right after closing the options dialog it will crash because the globals are getting deleted but the options dialog is still trying to use them. It has probably always been this way but for some reason drawing in non-OpenGL is much slower in MUI than in master.

@tai-fun
Copy link

tai-fun commented Dec 8, 2018 via email

@bdbcat
Copy link
Member

bdbcat commented Dec 8, 2018

Fixed.
Simple problem. O was calling GL driver to detect some capabilities, but the driver context had not been setup since GL mode was not active. Probably been that way forever...

@tai-fun
Copy link

tai-fun commented Dec 8, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants