Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashb. Add watchdog to Wind, Depth and STW data. #1550

Closed
wants to merge 1 commit into from

Conversation

Hakansv
Copy link
Contributor

@Hakansv Hakansv commented Dec 21, 2019

Fix most of Flyspray FS#2391.
@transmitterdan Comments? More to add?

@rgleason
Copy link
Collaborator

rgleason commented Dec 21, 2019

Why not adopt Petri's Dashboard-Tactics?
https://github.com/canne/dashboard_tactics_pi

See #1481

It has been extensively tested and is more accurate and reliable.
https://github.com/canne/dashboard_tactics_pi/blob/pr151/docs/developers/README.md

Or are you all in the NIH (Not invented here) mode?

@bdbcat
Copy link
Member

bdbcat commented Dec 21, 2019

re:
"Or are you all in the NIH (Not invented here) mode?"
Rick, this sort of provocative comment is really not appropriate nor necessary here. It is this kind of discourse that drives good developers away from FOSS projects. We are all working on O because we want to.
Let's play nice in the sandbox.

And btw, I don't actually see a PR for adopting Petri's work....
Dave

@rgleason
Copy link
Collaborator

rgleason commented Dec 21, 2019

Ok, sorry about that.

Yes, Petri never made such a PR, probably because he had doubts about it being accepted, however he did create a compile switch that will just build the Dashboard Instruments without Tactics, or with another switch setting create Dashboard and Tactics Instruments.

Which way would you like it?

@rgleason
Copy link
Collaborator

In cmakelists.txt Line 26

# ON = performance instruments, OFF = exclude all tactics_pi originated code from compilation _and_ build
SET(TACTICS_INSTRUMENTS ON)

Sometime when the dust has settled on the recent PR's I'll make a PR for just the Dashboard Instruments.

@Hakansv
Copy link
Contributor Author

Hakansv commented Dec 21, 2019

Despite conversation I've to close and come back. Typo and a Git-miss

@Hakansv Hakansv closed this Dec 21, 2019
@Hakansv Hakansv deleted the DashWatchdog branch December 21, 2019 23:18
@rgleason
Copy link
Collaborator

Hakan. Not a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants