Brgdist

[brianalex]

This pull adds 'bearing/distance to cursor from ownship'. Only the dashboard is affected. There are no references to the core program. The bearingdistance mercator is duplicated. This feature allows one to duplicate info from the status bar into the dashboard. With the Status Bar off, vertical screen space is increased, especially important in 600 pixel netbook screens.

[SethDart]

Hi Alex,

There's another pull request for that feature: #10

If you read comments there, you'll see that it's decided to postpone such changes until the API is expanded with the required functions (DistanceBearingMercator here)

Your code looks nice but I'd suggest a few changes:
You add some variables to dashboard_pi (mlat, mlon) and you do the computation there before sending the result to your instrument (you created two new sentences in instrument.h for that purpose). IMHO, you should request ship position (LAT & LON) and cursor position (PLA & PLO) in your instrument and do the math there. It should be enough. That would remove all the changes to SetPositionFix and SetCursorLatLon so they stay as generic as possible.

Please comment ;-)

[brianalex]

Hi
I should have checked out the pull request you mention. My bad. I will cancel my pull request and continue to use the feature for my own use until you implement this feature later.
Thanks for the coding suggestions. If I can figure out how to do it, I will make the changes you mentioned. I am new to C++ so your suggestions are very much appreciated.
Thanks
Brian

[SethDart]

You can keep this open, the other one is based on previous dashboard while your's is working on our latest version.

Here are the proposed changes:

in brgdist.cpp change constructor to

DashboardInstrument_BrgDist::DashboardInstrument_BrgDist(wxWindow *pparent, wxWindowID id, wxString title)
:DashboardInstrument(pparent, id, title, OCPN_DBP_STC_LAT|OCPN_DBP_STC_LON|OCPN_DBP_STC_PLA|OCPN_DBP_STC_PLO)

You can remove all m_cap_flag1 and m_cap_flag2 they are static for this instrument, IE not to be set in dashboard_pi (or the instrument would not work)

You'll need to store lat, lon, cursor lat and cursor long. In SetData you'll receive the 4 sentences. One received, you can compute brg & rng and store it for later display.

[brianalex]

Okay. I'll reopen the pull request as is, and update when the proposed changes are completed. Is this the proper way to do it on GitHub? Thanks for the help.

[SethDart]

As you may have noticed, the plugin API was updated with appropriate georef functions.
See this commit for reference: 388f061

Would you mind to update your changes and reopen this pull request?

[brianalex]

Hi
As a novice, I need help accessing the the georef functions from the new plugin API.
I keep getting
error LNK2019: unresolved external symbol _DistanceBearingMercator referenced .....

What do I need in the plugin file to access

extern "C" void DistanceBearingMercator(double lat0, double lon0, double lat1, double lon1, double *brg, double *dist);

from ocpn_plugin.h ???
Thanks for the help.
BrianBrian----- Original Message -----

From: SethDart
To: OpenCPN/OpenCPN
Cc: Brian Alexander
Sent: Wednesday, November 07, 2012 5:26 PM
Subject: Re: [OpenCPN] Brgdist (#33)

As you may have noticed, the plugin API was updated with appropriate georef functions.
See this commit for reference: 388f061

Would you mind to update your changes and reopen this pull request?

—
Reply to this email directly or view it on GitHub.