You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On Win10:
One issue noted:
Dashboard satellite instrument GPS.cpp have got to distinct background color for the signal to noise rectangles and info text.
One temporary hack to set it back is to use the former color scheme for the rectangles. We may not need to make this background color user adjustable?
+++ b/plugins/dashboard_pi/src/gps.cpp
@@ -363,7 +363,7 @@ void DashboardInstrument_GPS::DrawForeground(wxGCDC* dc) {
cl = GetColourSchemeFont(m_Properties->m_DataFont.GetColour());
else
cl = GetColourSchemeFont(g_pFontData->GetColour());
//GetGlobalColor(_T("DASHL"), &cl);
GetGlobalColor(_T("DASHL"), &cl);
First picture this commit, second after the "hack" above.
Another note:
When build it locally I need to clean out trailing whitespace and EOF extra blank lines.
Is it possible to clean that before next possible master load?
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced the dashboard code with the fork mentioned in #3547 and fixed it to actually build with
-fpermissive
not enabled