Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WithFiles was not requested when full export of report (#686) #687

Merged
merged 3 commits into from
Jun 24, 2024

Conversation

aHenryJard
Copy link
Member

@aHenryJard aHenryJard commented Jun 20, 2024

Proposed changes

  • Add the "WithFiles" args to True when export mode equals "full" for both report list and report alone export.

Tested locally: full export of a report has now the attach file in exported json, simple export of report does not have the attach file on json.

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@aHenryJard aHenryJard linked an issue Jun 20, 2024 that may be closed by this pull request
@aHenryJard aHenryJard marked this pull request as draft June 20, 2024 09:27
@aHenryJard aHenryJard marked this pull request as ready for review June 20, 2024 11:18
@SamuelHassine SamuelHassine merged commit e5f6120 into master Jun 24, 2024
6 checks passed
@SamuelHassine SamuelHassine deleted the issue/7051-report-export branch June 24, 2024 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export Attached file in context of full export
2 participants