Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve pdf generation done by the connector import-external-reference #1699

Merged
merged 5 commits into from
Jan 16, 2024
Merged

Improve pdf generation done by the connector import-external-reference #1699

merged 5 commits into from
Jan 16, 2024

Conversation

Lhorus6
Copy link
Contributor

@Lhorus6 Lhorus6 commented Jan 15, 2024

Everything is explained in the issue linked to this PR : #1698

Proposed changes

  • Install v0.12.6 of the wkhtmltopdf utility

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion) -> N/A
  • Where necessary I refactored code to improve the overall quality -> N/A

@Lhorus6 Lhorus6 added the filigran team use to identify PR from the Filigran team label Jan 15, 2024
@Lhorus6 Lhorus6 linked an issue Jan 15, 2024 that may be closed by this pull request
Enhanced pdfs generated by the import-external-reference enrichment connector #1698
Closed
lndrtrbn
lndrtrbn reviewed Jan 15, 2024
View reviewed changes
Copy link
Member

@lndrtrbn lndrtrbn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not an expert in Debian but I think we can specify a package version during apt install with this format: wkhtmltopdf=0.12.6-1.

It won't work here instead of install it manually ?

@Lhorus6
Copy link
Contributor Author

Lhorus6 commented Jan 15, 2024

@lndrtrbn I'm not an expert either but I think it works especially to recover an earlier version. If the debian repo does not reference the new version, there is no way to do this. I could be wrong

@Lhorus6 @aHenryJard
Change the package manager (for consistency)
37277da 
Co-authored-by: A. Jard <angelique.jard@gmail.com>
aHenryJard
aHenryJard approved these changes Jan 16, 2024
View reviewed changes
Copy link
Member

@aHenryJard aHenryJard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, docker build tested locally and is all fine.

@SamuelHassine SamuelHassine merged commit d666818 into master Jan 16, 2024
2 checks passed
@SamuelHassine SamuelHassine deleted the issue/1698 branch January 16, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aHenryJard aHenryJard aHenryJard approved these changes

@lndrtrbn lndrtrbn lndrtrbn approved these changes

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced pdfs generated by the import-external-reference enrichment connector
4 participants
@Lhorus6 @aHenryJard @lndrtrbn @SamuelHassine