Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[templates] fix typos and add metrics for external-import #1980

Merged
merged 1 commit into from
Mar 31, 2024
Merged

[templates] fix typos and add metrics for external-import #1980

merged 1 commit into from
Mar 31, 2024

Conversation

axelfahy
Copy link
Contributor

Proposed changes

  • Fix typos in the templates of the external-import connector
  • Fix some pylint warnings
  • Add metrics in the template

Related issues

  • N/A

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@SamuelHassine SamuelHassine merged commit c036435 into OpenCTI-Platform:master Mar 31, 2024
3 checks passed
sudesh0sudesh pushed a commit to sudesh0sudesh/connectors that referenced this pull request May 3, 2024
@axelfahy @sudesh0sudesh
[templates] fix typos and add metrics for external-import (OpenCTI-Pl…
5e5fa98 
…atform#1980)

Co-authored-by: sqooba_axel <sqooba_axel@knight.zoo>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@axelfahy @SamuelHassine