Diode import connector (#2009) #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| self.helper.connect_validate_before_import = connector.get( | ||
| "validate_before_import", False | ||
| ) | ||
| self.helper.applicant_id = self.applicant_mappings.get(applicant_id) |
There was a problem hiding this comment.
Tested locally in pair programming with @Megafredo in the following case:
- Run a connector with the following configurations
send_to_queue: False
send_to_directory: True
send_to_directory_path: "PATH_TO_DIRECTORY"
send_to_directory_retention: 1- Run the diode import connector with the following configurations
diode_import:
get_from_directory_path: 'PATH_TO_DIRECTORY'
get_from_directory_retention: 7
applicant_mappings: "source_user_id1:target_user_id1,source_user_id2:target_user_id2"Even if the self.helper.applicant_id is None (in case of applicant_mappings not properly set with correct id), data is still ingested with the correct creator and author is the correct one.
When is it used?
Can we discuss about that and about some additionnal suggestions?
There was a problem hiding this comment.
Its because you test on the same platform so the applicant are "magically aligned" :)
| @@ -0,0 +1,13 @@ | |||
| version: '3' | |||
| services: | |||
| connector-google-drive: | |||
There was a problem hiding this comment.
Suggested change
| connector-google-drive: | |
| connector-diode-import: |
Align name
Megafredo
approved these changes
Apr 8, 2024
helene-nguyen
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See OpenCTI-Platform/client-python#603 and #2009