Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix File created_by_ref and add error catch #2016

Merged
merged 2 commits into from
Apr 15, 2024
Merged

fix File created_by_ref and add error catch #2016

merged 2 commits into from
Apr 15, 2024

Conversation

yassine-ouaamou
Copy link
Member

Proposed changes

  • Put created_by_ref in custom_properties for File
  • Print exception when catched

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@yassine-ouaamou yassine-ouaamou marked this pull request as ready for review April 8, 2024 17:16
@yassine-ouaamou yassine-ouaamou added the filigran team use to identify PR from the Filigran team label Apr 15, 2024
@yassine-ouaamou yassine-ouaamou merged commit 5425abf into master Apr 15, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo left review comments

@Lhorus6 Lhorus6 Lhorus6 approved these changes

@helene-nguyen helene-nguyen Awaiting requested review from helene-nguyen

Assignees
No one assigned
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yassine-ouaamou @Megafredo @Lhorus6