Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RF Enrichment] Make RF enrichment connector playbook compliant #2018

Merged
merged 1 commit into from
Apr 15, 2024
Merged

[RF Enrichment] Make RF enrichment connector playbook compliant #2018

merged 1 commit into from
Apr 15, 2024

Conversation

helene-nguyen
Copy link
Member

@helene-nguyen helene-nguyen commented Apr 10, 2024 •
edited

Proposed changes

  • Update RF enrichment connector to be playbook compatible
  • Update related configuration files
  • Remove confidence level in connector as it is deprecated since >= 6.0

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@helene-nguyen helene-nguyen added the filigran team use to identify PR from the Filigran team label Apr 10, 2024
@helene-nguyen helene-nguyen self-assigned this Apr 10, 2024
@helene-nguyen helene-nguyen linked an issue Apr 10, 2024 that may be closed by this pull request
Make RF playbook compatible #1839
Closed
@helene-nguyen helene-nguyen marked this pull request as ready for review April 11, 2024 05:29
Megafredo
Megafredo approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@Megafredo Megafredo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's ok for me ! :)

@helene-nguyen helene-nguyen merged commit 5059f20 into master Apr 15, 2024
3 checks passed
@helene-nguyen helene-nguyen deleted the issue/1839-rf-enrichment branch April 15, 2024 06:18
yassine-ouaamou pushed a commit that referenced this pull request May 6, 2024
@helene-nguyen @yassine-ouaamou
[RF Enrichment] Make RF enrichment connector playbook compliant (#2018)
c8ac8e1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Megafredo Megafredo Megafredo approved these changes

@SamuelHassine SamuelHassine Awaiting requested review from SamuelHassine

@aHenryJard aHenryJard Awaiting requested review from aHenryJard

Assignees

@helene-nguyen helene-nguyen

Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make RF playbook compatible
2 participants
@helene-nguyen @Megafredo