Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ThreatFox] Added if statement to send_stix2_bundle #2024

Merged
merged 2 commits into from
Apr 17, 2024
Merged

[ThreatFox] Added if statement to send_stix2_bundle #2024

merged 2 commits into from
Apr 17, 2024

Conversation

annoyingapt
Copy link
Contributor

Proposed changes

  • Added an objects if statement before send_stix2_bundle. When setting THREATFOX_IMPORT_OFFLINE to false, it is possible to have a bundle with 0 objects, which causes an error.
  • Moved the debug print to before send_stix2_bundle so it prints when send_stix2_bundle is causing an error.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

yassine-ouaamou
yassine-ouaamou approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@yassine-ouaamou yassine-ouaamou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good for me. Thanks @annoyingapt

@yassine-ouaamou yassine-ouaamou added the community use to identify PR from community label Apr 15, 2024
@Jipegien Jipegien added this to the Release 6.2.0 milestone Apr 17, 2024
@SamuelHassine SamuelHassine merged commit ee55a12 into OpenCTI-Platform:master Apr 17, 2024
3 checks passed
@SamuelHassine SamuelHassine removed this from the Release 6.2.0 milestone Apr 17, 2024
yassine-ouaamou pushed a commit that referenced this pull request May 6, 2024
@annoyingapt @yassine-ouaamou
[threatfox] Added if statement to send_stix2_bundle (#2024)
2596863
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yassine-ouaamou yassine-ouaamou yassine-ouaamou approved these changes

Assignees
No one assigned
Labels
community use to identify PR from community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@annoyingapt @yassine-ouaamou @SamuelHassine @Jipegien