[Urlscan] Create an enrichment connector #2155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
helene-nguyen
force-pushed
the
opencti/issue/1103-urlscan
branch
from
762e9a8
to
d34eba1
Compare
Comment on lines
+131
to
+136
| if is_submission is True: | ||
| prepared_file_png = ( | ||
| self.utils.prepare_file_png(data) | ||
| if self.config.import_screenshot | ||
| else None | ||
| ) |
There was a problem hiding this comment.
When import_screenshot configuration is false, sending None seems to cause an error when enriching an observable
In the worker:
|
All good for me, tested locally and it works fine :) |
helene-nguyen
approved these changes
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Related issues
Checklist
Further comments