Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VirusTotal fixes #967

Merged
merged 2 commits into from
Jan 8, 2023
Merged

VirusTotal fixes #967

merged 2 commits into from
Jan 8, 2023

Conversation

sc0ttes
Copy link
Contributor

@sc0ttes sc0ttes commented Jan 5, 2023

Proposed changes

  • Add delay if connector fails to start because it can't make a connection to the OpenCTI platform (following the template's example)
  • When VirusTotal connector had auto-enrichment enabled, if a large artifact file was uploaded, it took a few seconds to finish uploading to OpenCTI and propagate through the system. The VT connector would fail with a list index exception when looking for the "importFiles" list. Adding a small delay and updating the observable variable allows for that propagation time to complete before moving on with the process.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality using different use cases
    • Tested with multiple file sizes
    • Tested with bringing services up slowly
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SamuelHassine SamuelHassine merged commit c8f72a8 into OpenCTI-Platform:master Jan 8, 2023
@sc0ttes sc0ttes deleted the virustotal-fixes branch January 8, 2023 20:58
SYNchroACK pushed a commit to SYNchroACK/opencti-connectors that referenced this pull request Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants