[frontend] improve e2e tests (#6343)

opencti-platform/opencti-front/src/private/components/common/stix_core_relationships/StixCoreRelationshipCreationFromEntity.tsx

@@ -516,7 +516,7 @@ const StixCoreRelationshipCreationFromEntity: FunctionComponent<StixCoreRelation
 
   const renderSelectEntity = () => {
     return (
-      <>
+      <div data-testid="stixCoreRelationshipCreationFromEntity-component">
         <div className={classes.header}>
           <IconButton
             aria-label="Close"
@@ -678,7 +678,7 @@ const StixCoreRelationshipCreationFromEntity: FunctionComponent<StixCoreRelation
           </Fab>
           )}
         </div>
-      </>
+      </div>
     );
   };
 

opencti-platform/opencti-front/tests_e2e/intrusionSet/createIntrusionSetRelationship.spec.ts

@@ -2,11 +2,13 @@ import { expect, test } from '../fixtures/baseFixtures';
 import IntrusionSetPage from '../model/intrusionSet.pageModel';
 import IntrusionSetFormPage from '../model/intrusionSetForm.pageModel';
 import IntrusionSetDetailsPage from '../model/intrusionSetDetails.pageModel';
+import StixCoreRelationshipCreationFromEntityFormPage from '../model/stixCoreRelationshipCreationFromEntityForm.pageModel';
 
 test('Create a new relationship in intrusion set knowledge', async ({ page }) => {
   const intrusionSetPage = new IntrusionSetPage(page);
   const intrusionSetForm = new IntrusionSetFormPage(page);
   const intrusionSetDetailsPage = new IntrusionSetDetailsPage(page);
+  const stixCoreRelationshipCreationFromEntity = new StixCoreRelationshipCreationFromEntityFormPage(page);
   await page.goto('/dashboard/threats/intrusion_sets');
   await intrusionSetPage.addNewIntrusionSet();
   await intrusionSetForm.fillNameInput('Test e2e');
@@ -16,5 +18,5 @@ test('Create a new relationship in intrusion set knowledge', async ({ page }) =>
   await intrusionSetDetailsPage.getKnowledgeTab();
   await intrusionSetDetailsPage.getVictimologyTab();
   await intrusionSetDetailsPage.getCreateRelationshipButton().click();
-  await expect(intrusionSetDetailsPage.getStixCoreRelationshipCreationFromEntityComponent()).toBeVisible();
+  await expect(stixCoreRelationshipCreationFromEntity.getStixCoreRelationshipCreationFromEntityComponent()).toBeVisible();
 });

opencti-platform/opencti-front/tests_e2e/model/intrusionSetDetails.pageModel.ts

@@ -23,8 +23,4 @@ export default class IntrusionSetDetailsPage {
   getCreateRelationshipButton() {
     return this.page.getByLabel('Add', { exact: true });
   }
-
-  getStixCoreRelationshipCreationFromEntityComponent() {
-    return this.page.getByRole('heading', { name: 'Create a relationship' });
-  }
 }

opencti-platform/opencti-front/tests_e2e/model/stixCoreRelationshipCreationFromEntityForm.pageModel.ts

@@ -0,0 +1,10 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Page } from '@playwright/test';
+
+export default class StixCoreRelationshipCreationFromEntityFormPage {
+  constructor(private page: Page) {}
+
+  getStixCoreRelationshipCreationFromEntityComponent() {
+    return this.page.getByTestId('stixCoreRelationshipCreationFromEntity-component');
+  }
+}