[backend] Fix tests (#issue/4911)

OpenCTI-Platform · Nov 22, 2023 · 439f726 · 439f726
1 parent b46f068
commit 439f726
Show file tree

Hide file tree

Showing 4 changed files with 246 additions and 128 deletions.
diff --git a/opencti-platform/opencti-graphql/src/domain/container.js b/opencti-platform/opencti-graphql/src/domain/container.js
@@ -4,7 +4,6 @@ import { RELATION_OBJECT } from '../schema/stixRefRelationship';
 import { listAllThings, listThings } from '../database/middleware';
 import {
   internalFindByIds,
-  internalLoadById,
   listAllRelations,
   listEntities,
   storeLoadById
@@ -19,7 +18,7 @@ import {
 import { isStixDomainObjectContainer } from '../schema/stixDomainObject';
 import { buildPagination, isInferredIndex, READ_INDEX_STIX_DOMAIN_OBJECTS } from '../database/utils';
 import { now } from '../utils/format';
-import { elCount } from '../database/engine';
+import { elBatchIds, elCount } from '../database/engine';
 import { findById as findInvestigationById } from '../modules/workspace/workspace-domain';
 import { stixCoreObjectAddRelations } from './stixCoreObject';
 
@@ -151,8 +150,8 @@ export const containersObjectsOfObject = async (context, user, { id, types, filt
 
 export const filterUnwantedEntitiesOut = async ({ context, user, ids }) => {
   const filteredOutInvestigatedIds = [];
-  ids.forEach((id) => {
-    const entity = internalLoadById(context, user, id);
+  const entities = await elBatchIds(context, user, ids);
+  entities?.forEach((entity) => {
     if (!['Task', 'Note'].includes(entity.entity_type)) {
       filteredOutInvestigatedIds.push(entity.id);
     }
@@ -162,7 +161,7 @@ export const filterUnwantedEntitiesOut = async ({ context, user, ids }) => {
 
 export const knowledgeAddFromInvestigation = async (context, user, { containerId, workspaceId }) => {
   const investigation = await findInvestigationById(context, user, workspaceId);
-  const ids = investigation.investigated_entities_ids.filter((id) => id !== containerId);
+  const ids = investigation.investigated_entities_ids?.filter((id) => id !== containerId);
   const toIds = await filterUnwantedEntitiesOut({ context, user, ids });
   const containerInput = { toIds, relationship_type: 'object' };
   return await stixCoreObjectAddRelations(context, user, containerId, containerInput);