[backend] check complex object even if not mandatory

OpenCTI-Platform · Feb 27, 2024 · 9384a8c · 9384a8c
1 parent e242569
commit 9384a8c
Showing 1 changed file with 7 additions and 9 deletions.
diff --git a/opencti-platform/opencti-graphql/src/schema/schema-attributes.ts b/opencti-platform/opencti-graphql/src/schema/schema-attributes.ts
@@ -240,18 +240,16 @@ const validateInputAgainstSchema = (input: any, schemaDef: AttributeDefinition)
   }
 
   if (isNonFlatObjectAttributeMapping(schemaDef)) {
-    // check 'multiple' constraint
-    if (isMandatory) {
-      if (schemaDef.multiple && !Array.isArray(input)) {
-        throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: value must be an array`, { value: input });
-      }
-      if (!schemaDef.multiple && (Array.isArray(input) || !R.is(Object, input))) {
-        throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: value must be an object`, { value: input });
-      }
-    }
     if (!isMandatory && R.isNil(input)) {
       return; // nothing to check (happens on 'remove' operation for instance
     }
+    // check 'multiple' constraint
+    if (schemaDef.multiple && !Array.isArray(input)) {
+      throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: value must be an array`, { value: input });
+    }
+    if (!schemaDef.multiple && (Array.isArray(input) || !R.is(Object, input))) {
+      throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: value must be an object`, { value: input });
+    }
 
     const inputValues = Array.isArray(input) ? input : [input];
     inputValues.forEach((value) => {