[frontend] Impossible to create a relationship from an entity "knowle…

…dge" view (#6343)

opencti-platform/opencti-front/src/private/components/common/stix_core_relationships/StixCoreRelationshipCreationFromEntity.tsx

@@ -313,7 +313,7 @@ const StixCoreRelationshipCreationFromEntity: FunctionComponent<StixCoreRelation
   );
   const [selectedElements, setSelectedElements] = useState<Record<string, StixCoreRelationshipCreationFromEntityStixCoreObjectsLine_node$data>>({});
   useEffect(() => {
-    if (targetEntitiesProps !== targetEntities) {
+    if (!R.equals(targetEntitiesProps, targetEntities) && targetEntitiesProps.length > targetEntities.length) {
       setTargetEntities(targetEntitiesProps);
       setStep(targetEntitiesProps.length === 0 ? 0 : 1);
       setOpen(targetEntitiesProps.length !== 0);

opencti-platform/opencti-front/src/private/components/threats/intrusion_sets/Root.jsx

@@ -129,6 +129,7 @@ class RootIntrusionSet extends Component {
                         ? 200
                         : 0,
                     }}
+                    data-testid="intrusionSet-details-page"
                   >
                     <Breadcrumbs variant="object" elements={[
                       { label: t('Threats') },
@@ -214,10 +215,12 @@ class RootIntrusionSet extends Component {
                       <Route
                         path="/dashboard/threats/intrusion_sets/:intrusionSetId/knowledge"
                         render={(routeProps) => (
-                          <IntrusionSetKnowledge
-                            {...routeProps}
-                            intrusionSet={props.intrusionSet}
-                          />
+                          <div data-testid="instrusionSet-knowledge">
+                            <IntrusionSetKnowledge
+                              {...routeProps}
+                              intrusionSet={props.intrusionSet}
+                            />
+                          </div>
                         )}
                       />
                       <Route

opencti-platform/opencti-front/tests_e2e/dashboard/createDashboard.spec.ts

@@ -22,5 +22,5 @@ test('Create a new dashboard page', async ({ page }) => {
   await dashboardDetailsPage.getDeleteButton().click();
   await dashboardDetailsPage.getDelete().click();
   await page.goto('/dashboard/workspaces/dashboards');
-  await expect(page.getByRole('link', {name: 'Test e2e'})).toBeHidden();
+  await expect(page.getByRole('link', { name: 'Test e2e' })).toBeHidden();
 });

opencti-platform/opencti-front/tests_e2e/intrusionSet/createIntrusionSetRelationship.spec.ts

@@ -0,0 +1,20 @@
+import { expect, test } from '../fixtures/baseFixtures';
+import IntrusionSetPage from '../model/intrusionSet.pageModel';
+import IntrusionSetFormPage from '../model/intrusionSetForm.pageModel';
+import IntrusionSetDetailsPage from '../model/intrusionSetDetails.pageModel';
+
+test('Create a new relationship in intrusion set knowledge', async ({ page }) => {
+  const intrusionSetPage = new IntrusionSetPage(page);
+  const intrusionSetForm = new IntrusionSetFormPage(page);
+  const intrusionSetDetailsPage = new IntrusionSetDetailsPage(page);
+  await page.goto('/dashboard/threats/intrusion_sets');
+  await intrusionSetPage.addNewIntrusionSet();
+  await intrusionSetForm.fillNameInput('Test e2e');
+  await intrusionSetPage.getCreateIntrusionSetButton().click();
+  await intrusionSetPage.getItemFromList('Test e2e').click();
+  await expect(intrusionSetDetailsPage.getIntrusionSetDetailsPage()).toBeVisible();
+  await intrusionSetDetailsPage.getKnowledgeTab();
+  await intrusionSetDetailsPage.getVictimologyTab();
+  await intrusionSetDetailsPage.getCreateRelationshipButton().click();
+  await expect(intrusionSetDetailsPage.getStixCoreRelationshipCreationFromEntityComponent()).toBeVisible();
+});

opencti-platform/opencti-front/tests_e2e/model/intrusionSet.pageModel.ts

@@ -0,0 +1,22 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Page } from '@playwright/test';
+
+export default class IntrusionSetPage {
+  constructor(private page: Page) {}
+
+  getPage() {
+    return this.page.getByTestId('instrusionSet-knowledge');
+  }
+
+  addNewIntrusionSet() {
+    return this.page.getByLabel('Add', { exact: true }).click();
+  }
+
+  getCreateIntrusionSetButton() {
+    return this.page.getByRole('button', { name: 'Create', exact: true });
+  }
+
+  getItemFromList(name: string) {
+    return this.page.getByRole('link', { name }).first();
+  }
+}

opencti-platform/opencti-front/tests_e2e/model/intrusionSetDetails.pageModel.ts

@@ -0,0 +1,30 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Page } from '@playwright/test';
+
+export default class IntrusionSetDetailsPage {
+  constructor(private page: Page) {}
+
+  getIntrusionSetDetailsPage() {
+    return this.page.getByTestId('intrusionSet-details-page');
+  }
+
+  getTitle(name: string) {
+    return this.page.getByRole('heading', { name });
+  }
+
+  getKnowledgeTab() {
+    return this.page.getByRole('tab', { name: 'Knowledge' }).click();
+  }
+
+  getVictimologyTab() {
+    return this.page.getByRole('menuitem', { name: 'Victimology' }).click();
+  }
+
+  getCreateRelationshipButton() {
+    return this.page.getByLabel('Add', { exact: true });
+  }
+
+  getStixCoreRelationshipCreationFromEntityComponent() {
+    return this.page.getByRole('heading', { name: 'Create a relationship' });
+  }
+}

opencti-platform/opencti-front/tests_e2e/model/intrusionSetForm.pageModel.ts

@@ -0,0 +1,15 @@
+// eslint-disable-next-line import/no-extraneous-dependencies
+import { Page } from '@playwright/test';
+
+export default class IntrusionSetFormPage {
+  constructor(private page: Page) {}
+
+  getNameInput() {
+    return this.page.getByRole('textbox', { name: 'Name' });
+  }
+
+  async fillNameInput(input: string) {
+    await this.getNameInput().click();
+    return this.getNameInput().fill(input);
+  }
+}