[backend] improve tests

OpenCTI-Platform · Feb 23, 2024 · ea5aee0 · ea5aee0
1 parent 93496ec
commit ea5aee0
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 2 deletions.
diff --git a/opencti-platform/opencti-graphql/src/domain/stixCoreObject.js b/opencti-platform/opencti-graphql/src/domain/stixCoreObject.js
@@ -404,7 +404,7 @@ export const stixCoreObjectImportPush = async (context, user, id, file, noTrigge
     await elUpdateElement({
       _index: previous._index,
       internal_id: internalId,
-      entity_type: previous.entity_type,
+      entity_type: previous.entity_type, // required for schema validation
       updated_at: now(),
       x_opencti_files: files
     });

diff --git a/opencti-platform/opencti-graphql/src/schema/schema-attributes.ts b/opencti-platform/opencti-graphql/src/schema/schema-attributes.ts
@@ -236,7 +236,7 @@ export const isNonFLatObjectAttributeMapping = (schemaDef: AttributeDefinition)
 const validateInputAgainstSchema = (input: any, schemaDef: AttributeDefinition) => {
   const isMandatory = isMandatoryAttributeMapping(schemaDef);
   if (isMandatory && R.isNil(input)) {
-    throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: attribute is mandatory but not present`);
+    throw FunctionalError(`Validation against schema failed on attribute [${schemaDef.name}]: this mandatory field cannot be nil`, { value: input });
   }
 
   if (isNonFLatObjectAttributeMapping(schemaDef)) {

diff --git a/opencti-platform/opencti-graphql/tests/01-unit/database/validateDataBeforeIndexing-test.ts b/opencti-platform/opencti-graphql/tests/01-unit/database/validateDataBeforeIndexing-test.ts
@@ -98,6 +98,19 @@ describe('validateDataBeforeIndexing', () => {
     expect(() => validateDataBeforeIndexing(invalidUser))
       .toThrowError('Validation against schema failed on attribute [overrides]: mandatory field [entity_type] is not present');
 
+    invalidUser = {
+      ...user,
+      user_confidence_level: {
+        max_confidence: null, // mandatory field to null
+        overrides: [{
+          max_confidence: 77,
+          entity_type: 'Report'
+        }]
+      },
+    };
+    expect(() => validateDataBeforeIndexing(invalidUser))
+      .toThrowError('Validation against schema failed on attribute [max_confidence]: this mandatory field cannot be nil');
+
     const invalidThreatActorIndividual = {
       ...threatActorIndividual,
       height: [{