Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CircleCI tests not passing from PR #160

Closed
SamuelHassine opened this issue Jul 26, 2019 · 0 comments · Fixed by #164
Closed

CircleCI tests not passing from PR #160

SamuelHassine opened this issue Jul 26, 2019 · 0 comments · Fixed by #164
Assignees
@SamuelHassine
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 1.1.1

Comments

@SamuelHassine
Copy link
Member

Description

The CircleCI tests are not passing when using PR because of the needs of environment variables that are provided only for building branches.

Environment

  1. CircleCI
  2. OpenCTI 1.1.0
@SamuelHassine SamuelHassine self-assigned this Jul 26, 2019
@SamuelHassine SamuelHassine added the bug use for describing something not working as expected label Jul 26, 2019
@SamuelHassine SamuelHassine added this to the Release 1.1.1 milestone Jul 26, 2019
SamuelHassine pushed a commit that referenced this issue Jul 26, 2019
[build] Add environment variables to the CircleCI workflowa (#160)
ad0e50f
SamuelHassine pushed a commit that referenced this issue Jul 26, 2019
[build] Add environment variables to the CircleCI workflow (#160)
bbe433c
richard-julien pushed a commit that referenced this issue Jul 27, 2019
@richard-julien
[build] Add environment variables to the CircleCI workflow (#160) (#161)
7269474 
* Add environment variables to the CircleCI workflow (Fix #160)
@SamuelHassine SamuelHassine mentioned this issue Jul 28, 2019
Merged
SamuelHassine pushed a commit that referenced this issue Jul 29, 2019
[build] Add environment variables to the CircleCI workflow (#160) (#161)
cd56b8b 
* Add environment variables to the CircleCI workflow (Fix #160)
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jul 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelHassine SamuelHassine

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 1.1.1
Development

Successfully merging a pull request may close this issue.

[build] Add environment variables to the CircleCI workflow (#160) (#161) OpenCTI-Platform/opencti
1 participant
@SamuelHassine