Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Japanese translation #2456

Closed
kohsawa opened this issue Oct 14, 2022 · 1 comment
Closed

Add Japanese translation #2456

kohsawa opened this issue Oct 14, 2022 · 1 comment
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 5.4.0

Comments

@kohsawa
Copy link
Contributor

kohsawa commented Oct 14, 2022

Use case

Users (mainly: Japanese speakers) will be able to choose Japanese as the displayed language.

Current Workaround

No

Proposed Solution

Add Japanese localization.

Additional Information

No

If the feature request is approved, would you be willing to submit a PR?

Yes, I've already made PR as #2455 .
@kohsawa kohsawa mentioned this issue Oct 14, 2022
Merged
5 tasks
@richard-julien richard-julien added the feature use for describing a new feature to develop label Oct 14, 2022
@richard-julien
Copy link
Member

Hi @kohsawa , thats really cool ! Thanks for the PR!

@richard-julien richard-julien added this to the Release 5.4.0 milestone Oct 14, 2022
richard-julien pushed a commit that referenced this issue Oct 14, 2022
@kohsawa @nimaike @minanokawari1124
[front] Add Japanese translation (#2456)
ff76182 
Co-authored-by: nimaike <nimaike@protonmail.com>
Co-authored-by: minanokawari <r.minakawa1124@gmail.com>
Co-authored-by: Hiroki Kubokawa <hiroki.kubokawa@nflabs.jp>
@richard-julien richard-julien added the solved use to identify issue that has been solved (must be linked to the solving PR) label Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 5.4.0
Development

No branches or pull requests
2 participants
@richard-julien @kohsawa