Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store the remote IDs in some ES entities is useless and performance killer #369

Closed
SamuelHassine opened this issue Dec 8, 2019 · 0 comments
Closed

Store the remote IDs in some ES entities is useless and performance killer #369

SamuelHassine opened this issue Dec 8, 2019 · 0 comments
Assignees
@richard-julien
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Milestone
Release 2.1.2

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Dec 8, 2019 •
edited

Description

In the model, embedded relations are registered on both sides. In some cases, this is useless and performance killer.

Solution

Remove the storage on the useless side in the following entities :

  • MarkingDefinition
  • KillChainPhase
  • Tag

Remember to create a migration to remove the field on these entities.
@SamuelHassine SamuelHassine added this to the Release 2.1.2 milestone Dec 8, 2019
@SamuelHassine SamuelHassine added bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed labels Dec 8, 2019
SamuelHassine pushed a commit that referenced this issue Dec 14, 2019
@richard-julien
[api] Do not store remote IDs on some embedded relations (#369)
681e8d3 
* Store the remote IDs in some ES entities is useless and performance killer
* Be able to redo the migration without error
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR) technical improvement Technical refactor or improvement is needed
Projects
None yet
Milestone
Release 2.1.2
Development

No branches or pull requests
2 participants
@richard-julien @SamuelHassine