Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot modify the name of an entity if already present in the alias of the same entity #4798

Closed
SamuelHassine opened this issue Oct 28, 2023 · 6 comments · Fixed by #4871
Closed
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@SamuelHassine
Copy link
Member

Description

Cannot modify the name of an entity if already present in the alias of the same entity.

Reproducible Steps

  1. Create an intrusion set "Intrusion Set A"
  2. Add the alias "Intrusion Set B" and "Intrusion Set A"
  3. Try to modify the name with "Intrusion Set B"
@SamuelHassine SamuelHassine added the bug use for describing something not working as expected label Oct 28, 2023
@SamuelHassine SamuelHassine modified the milestones: Release 5.12.0, Release 5.13.0, Release 5.11.13 Oct 29, 2023
@Megafredo Megafredo self-assigned this Oct 30, 2023
@Megafredo
Copy link
Member

version 5.11.12
I cannot reproduce the error, for my part the modification of the intrusion to a name identical to the alias is carried out correctly.
Here is the process history :
image

@SamuelHassine
Copy link
Member Author

@Megafredo
Copy link
Member

Hello,

Try here: https://testing.octi.staging.filigran.io/dashboard/threats/intrusion_sets/49abddab-a325-43cb-8e65-ca0187d1a408.

To put test in the name.

Indeed on the linked page the name change does not work, I will look at that !

@Kedae Kedae added the needs more info Intel needed about the use case label Nov 3, 2023
@Kedae
Copy link
Member

Kedae commented Nov 3, 2023

We have added this feature in 5778643, is that really a bug or a revert of that behavior ?

@Kedae Kedae removed the bug use for describing something not working as expected label Nov 3, 2023
@SamuelHassine
Copy link
Member Author

Thanks a lot @Kedae @Megafredo, well done.

Can you please add a note in https://docs.opencti.io/latest/usage/deduplication/?

With a form like:

image

Thanks!

@SamuelHassine SamuelHassine added question Further information is requested solved use to identify issue that has been solved (must be linked to the solving PR) and removed needs more info Intel needed about the use case labels Nov 6, 2023
@SamuelHassine SamuelHassine removed this from the Release 5.11.13 milestone Nov 6, 2023
@SamuelHassine
Copy link
Member Author

Still remaining case sensitive issue.

@SamuelHassine SamuelHassine reopened this Nov 6, 2023
@SamuelHassine SamuelHassine added bug use for describing something not working as expected and removed question Further information is requested solved use to identify issue that has been solved (must be linked to the solving PR) labels Nov 6, 2023
@Megafredo Megafredo linked a pull request Nov 9, 2023 that will close this issue
5 tasks
@SamuelHassine SamuelHassine removed this from the Release 5.12.0 milestone Dec 1, 2023
@SamuelHassine SamuelHassine modified the milestones: Release 5.12.1, Release 5.13.0, Release 5.12.0 Dec 1, 2023
@richard-julien richard-julien added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants