New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[frontend/backend] Fix changing entity name to same as alias #4871
Conversation
Would it make more sense for the user (in terms of UX) to have a validation in the form instead of "not doing the requested changes" being his back? I mean, you edit the name, put one of its alias, the form is red with proper error like "Cannot rename to an alias". IMO disallowing bad behavior with explanation is better UX (educating user). |
Yes indeed, having a visual way to communicate why adding the alias does not work can be a good approach (in terms of UX). |
setOpenCommitCreate(false); | ||
setNewAlias(''); | ||
resetForm(); | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest we display an error message here to notify the user that the alias can't be named the same as the entity name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Considering we leave the UX improvements for later, it looks ok to me !
Just thinking with Souad about a little missing piece at creation. |
3cc9d18
to
cb29cd7
Compare
…eating alias name to same as entity
d776dd5
to
90ab7ef
Compare
Proposed changes
Related issues
Checklist
Further comments
Behavior before fix :
Behavior after fix :