Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't remove search keyword from Global Search #5039

Closed
Archidoit opened this issue Dec 1, 2023 · 3 comments · Fixed by #5043
Closed

Can't remove search keyword from Global Search #5039

Archidoit opened this issue Dec 1, 2023 · 3 comments · Fixed by #5043
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)

Comments

@Archidoit
Copy link
Member

Description

Can't remove search keyword from Global Search

Reproducible Steps

Error when doing a Search

  • Do a global search with no filters (all the entities are displayed)
    image

  • enter a keyword in Search
    image

  • remove the keyword in Search, tap ENTER : the only entities displayed are the one respecting the previous search keyword
    image

  • if you reload the page, the keyword (’test’ in this example) comes back

Comment

The screenshort have been done with the new filters UI, but the bug is present in testing.

@Archidoit Archidoit added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Dec 1, 2023
@Jipegien Jipegien added critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team critical use to identify critical bug to fix ASAP labels Dec 1, 2023
@Jipegien
Copy link
Member

Jipegien commented Dec 1, 2023

When no filter active, this comportment is expected.
But if you have filter active, you should be able to search an "empty" key word (example : I search reports whit the name "blabla", but then I juste want to filter on reports)

@SamuelHassine SamuelHassine added this to the Release 5.12.1 milestone Dec 1, 2023
@Kedae
Copy link
Member

Kedae commented Dec 2, 2023

I don't get how this could be the expected behavior to have a search box emptied and not the according result.
I suggested a fix.

@Kedae Kedae self-assigned this Dec 2, 2023
@Kedae Kedae linked a pull request Dec 2, 2023 that will close this issue
@Jipegien
Copy link
Member

Jipegien commented Dec 2, 2023

I don't get how this could be the expected behavior to have a search box emptied and not the according result. I suggested a fix.

A search here with the box empty and no filter means to search everything on the entire platform. This is useless.

@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants