Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double quote are not taken into account in the file text indexing search #5129

Closed
Jipegien opened this issue Dec 6, 2023 · 0 comments · Fixed by #5139
Closed

Double quote are not taken into account in the file text indexing search #5129

Jipegien opened this issue Dec 6, 2023 · 0 comments · Fixed by #5139
Assignees
@SouadHadjiat
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 5.12.4

Comments

@Jipegien
Copy link
Member

Jipegien commented Dec 6, 2023

Description

When searching for a string with double quote, the search in texts from indexed files is done without the double quote

Environment

  1. OpenCTI version: 5.12.4 (testing)

Reproducible Steps

  • On testing platform, search "XL4 macros" (with double quotes)
  • click one of the result in the file tab
  • search the string "XL4 macros" directly in the pdf
  • no result (the matching string is "macros")

Expected Output

No results in the file tab, as no files contains the complete string "XL4 macros"

Actual Output

2 results
@Jipegien Jipegien added the bug use for describing something not working as expected label Dec 6, 2023
SouadHadjiat added a commit that referenced this issue Dec 7, 2023
@SouadHadjiat
[backend] Fix search in files query (#5129)
fea0855
@SouadHadjiat SouadHadjiat mentioned this issue Dec 7, 2023
Merged
5 tasks
@SouadHadjiat SouadHadjiat linked a pull request Dec 7, 2023 that will close this issue
[backend] Fix search in files query (#5129) #5139
Merged
5 tasks
SouadHadjiat added a commit that referenced this issue Dec 7, 2023
@SouadHadjiat
[backend] Fix search in files query (#5129)
a9c0947
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Dec 7, 2023
@SamuelHassine SamuelHassine reopened this Dec 7, 2023
@SamuelHassine SamuelHassine modified the milestones: Long-term candidates, Release 5.12.4 Dec 7, 2023
CelineSebe pushed a commit that referenced this issue Dec 8, 2023
@SouadHadjiat @CelineSebe
[backend] Fix search in files query (#5129)
a517f00
@richard-julien richard-julien mentioned this issue Dec 15, 2023
Merged
SamuelHassine pushed a commit that referenced this issue Dec 15, 2023
@richard-julien
[backend] Introduce mapping reset function for indices and templates (#…
5a55d24 
…5129)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SouadHadjiat SouadHadjiat

Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 5.12.4
Development

Successfully merging a pull request may close this issue.

[backend] Fix search in files query (#5129) OpenCTI-Platform/opencti
3 participants
@SouadHadjiat @SamuelHassine @Jipegien