Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Markdown in rich text fields is reverted when first applied #5943

Closed
JeremyCloarec opened this issue Feb 13, 2024 · 6 comments · Fixed by #6035
Closed

Markdown in rich text fields is reverted when first applied #5943

JeremyCloarec opened this issue Feb 13, 2024 · 6 comments · Fixed by #6035
Assignees
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@JeremyCloarec
Copy link
Contributor

Description

When typing in a rich text field and selecting a markdown, the markdown is first correctly applied, but is quickly reverted back.
See the linked video for a more explicit description

Environment

  1. OS (where OpenCTI server runs): Windows 10
  2. OpenCTI version: 5.12.29
  3. OpenCTI client: frontend
  4. Other environment details:

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Open Settings/Security/Roles
  2. Open and edit any role
  3. Write a text in the description field
  4. Apply a markdown

Expected Output

We expect the markdown to be correctly applied.

OpenCTI.-.Cyber.Threat.Intelligence.Platform.-.Work.-.Microsoft.Edge.2024-02-13.12-11-14.mp4
@JeremyCloarec JeremyCloarec added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Feb 13, 2024
@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Feb 14, 2024
@nino-filigran
Copy link

nino-filigran commented Feb 14, 2024

After trying to reproduce, it happens only in:

  • Groups
  • users
  • organisation
  • groups

@CelineSebe CelineSebe self-assigned this Feb 14, 2024
@CelineSebe
Copy link
Member

CelineSebe commented Feb 15, 2024

Tested locally. I didn't see any problem, the markdown is applied correctly after validation of the form

@nino-filigran
Copy link

nino-filigran commented Feb 15, 2024

@CelineSebe I don't know what to say, it happens on our internal platform, so we still have an issue:
image

Feel free to contact me so that I can show you the point.

@SamuelHassine SamuelHassine added this to the Release 6.0.0 milestone Feb 15, 2024
@nino-filigran
Copy link

nino-filigran commented Feb 15, 2024

@CelineSebe I think my comment was not 100% aligned with @JeremyCloarec 's bug.
There are 2 things:

  • indeed, when you modify an entity and try to apply a specific look and feel, it is not applied in the editor (cf his video)
  • additionally, the markodown style is not applied to the description (which is something different) - this does not happen on testing.

I've modified my comment since it applies everywhere, also in groups.

Are you aligned with testing?

@CelineSebe
Copy link
Member

CelineSebe commented Feb 15, 2024

Locally, I don't reproduce the bug in the video. Once validated (single click outside the input field), the description is updated with Markdown.

@CelineSebe CelineSebe removed their assignment Feb 15, 2024
@Jipegien
Copy link
Member

Jipegien commented Feb 16, 2024

The result of applying is not consistent. Sometimes it is removed, but not everytime. Seems related to the first try after opening the form.

@Jipegien Jipegien modified the milestones: Release 6.0.0, Release 6.0.1 Feb 16, 2024
@frapuks frapuks self-assigned this Feb 19, 2024
@JeremyCloarec JeremyCloarec linked a pull request Feb 19, 2024 that will close this issue
5 tasks
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants