Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Playbooks] remove marking definition doesn't work #5950

Closed
yassine-ouaamou opened this issue Feb 13, 2024 · 2 comments · Fixed by #5964
Closed

[Playbooks] remove marking definition doesn't work #5950

yassine-ouaamou opened this issue Feb 13, 2024 · 2 comments · Fixed by #5964
Assignees
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@yassine-ouaamou
Copy link
Member

Description

The action of removing marking definitions does not function in playbooks

Environment

Testing

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Have an entity with TLP:GREEN
  2. Create a playbook that does the following:
  • Listen to edition
  • Manipulate knowledge -> Remove - Marking definitions - TLP_GREEN
  • Send to Ingestion
  1. Start the playbook
  2. Edit a field of the entity

Expected Output

The marking TLP:GREEN is deleted

Actual Output

The marking TLP:GREEN is not deleted

Additional information

Because of this bug, the "Replace Marking Definition" doesn't work in some cases like when replacing TLP:RED by TLP:GREEN.
Since the remove doesn't work, the add is ignored as RED is higher that GREEN.
This case is interesting to check once the issue is fixed.

Screenshots (optional)

@yassine-ouaamou yassine-ouaamou added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Feb 13, 2024
@jborozco jborozco added critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Feb 14, 2024
@SouadHadjiat SouadHadjiat self-assigned this Feb 14, 2024
@SouadHadjiat SouadHadjiat linked a pull request Feb 14, 2024 that will close this issue
5 tasks
@SamuelHassine SamuelHassine added this to the Release 6.0.0 milestone Feb 15, 2024
Kedae pushed a commit that referenced this issue Feb 16, 2024
Co-authored-by: Julien Richard <julien.richard@filigran.io>
@Kedae Kedae added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 16, 2024
@Kedae Kedae reopened this Feb 16, 2024
@Kedae Kedae assigned SamuelHassine and unassigned SouadHadjiat Feb 16, 2024
@Kedae
Copy link
Member

Kedae commented Feb 16, 2024

Need to add a correct cleaning of action on front side

@richard-julien
Copy link
Member

Could be done along with OpenCTI-Platform/client-python#566

@SamuelHassine SamuelHassine removed the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 16, 2024
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 23, 2024
Archidoit pushed a commit that referenced this issue Jun 6, 2024
Co-authored-by: Julien Richard <julien.richard@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants