Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle revoked input for Indicators without valid_until date #6099

Closed
SouadHadjiat opened this issue Feb 23, 2024 · 0 comments · Fixed by #6148
Closed

Handle revoked input for Indicators without valid_until date #6099

SouadHadjiat opened this issue Feb 23, 2024 · 0 comments · Fixed by #6148
Assignees
@richard-julien
Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.0

Comments

@SouadHadjiat
Copy link
Member

SouadHadjiat commented Feb 23, 2024 •
edited

Use case

Currently we compute revoked based on valid_until date. We would like to be able to "force" revoke an indicator with revoked input parameter, which already exists.
One use case is we receive data of an indicator with a valid_from date and revoked: true, but no valid_until date. Currently we ignore the revoked parameter and set it according to a valid_until date that we compute (based on indicator lifetime).

Proposed Solution

We should save the revoked input when we don't have a valid_until date.

Additional Information

From this community slack conversation : https://filigran-community.slack.com/archives/C06CF1N302W/p1708686009120799
@SouadHadjiat SouadHadjiat added feature use for describing a new feature to develop needs triage use to identify issue needing triage from Filigran Product team labels Feb 23, 2024
@SouadHadjiat SouadHadjiat changed the title Handle revoke input for Indicators without valid_until date Handle revoked input for Indicators without valid_until date Feb 23, 2024
@richard-julien richard-julien self-assigned this Feb 26, 2024
@richard-julien richard-julien added this to the Release 6.0.0 milestone Feb 26, 2024
@Kedae Kedae removed the needs triage use to identify issue needing triage from Filigran Product team label Feb 26, 2024
richard-julien added a commit that referenced this issue Feb 27, 2024
@richard-julien
[backend] Handle revoked input for Indicators without valid_until date (
bc069d0 
#6099)
@richard-julien richard-julien mentioned this issue Feb 27, 2024
Merged
@richard-julien richard-julien linked a pull request Feb 27, 2024 that will close this issue
[backend] Handle revoked input for Indicators without valid_until date (#6099) #6148
Merged
richard-julien added a commit that referenced this issue Feb 27, 2024
@richard-julien
[backend] Handle revoked input for Indicators without valid_until date (
a088a1a 
#6099)
@richard-julien richard-julien added the solved use to identify issue that has been solved (must be linked to the solving PR) label Feb 27, 2024
Archidoit pushed a commit that referenced this issue Jun 6, 2024
@richard-julien @Archidoit
[backend] Handle revoked input for Indicators without valid_until date (
b96495f 
#6099)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@richard-julien richard-julien

Labels
feature use for describing a new feature to develop solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.0
3 participants
@richard-julien @SouadHadjiat @Kedae