Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In CSV Feed Ingester, take into account Default Marking definition options from CSV Mapper #6149

Closed
Jipegien opened this issue Feb 27, 2024 · 0 comments · Fixed by #7275
Closed

In CSV Feed Ingester, take into account Default Marking definition options from CSV Mapper #6149

Jipegien opened this issue Feb 27, 2024 · 0 comments · Fixed by #7275
Assignees
@Goumies @Jipegien
Labels
feature use for describing a new feature to develop ingestion Linked to ingestion (manual, from file, feeds & queue) solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.2.0

Comments

@Jipegien
Copy link
Member

Use case

In CSV Mapper, it is possible to choose between 2 options to add Marking definition to imported data when marking are not directly provided by the file's data.
image

When importing a file directly (for example via Data/Import), user is able to provide a marking definition to be used, if the right option in CSV mapper has been chosen.
image

But, when importing from a CSV feed ingester, user cannot define such a marking in the configuration of the csv feed.

We need to give user the ability to provide necessary Default marking definition in CSV feed configuration if the associated CSV mapper ask to do so.
@Jipegien Jipegien added the feature use for describing a new feature to develop label Feb 27, 2024
@Jipegien Jipegien modified the milestones: Release 6.0.1, Release 6.0.2 Feb 27, 2024
@Jipegien Jipegien modified the milestones: Release 6.1.0, Release 6.2.0 Mar 26, 2024
@SamuelHassine SamuelHassine added filigran team use to identify PR from the Filigran team and removed filigran team use to identify PR from the Filigran team labels Apr 20, 2024
@SouadHadjiat SouadHadjiat self-assigned this May 6, 2024
@SouadHadjiat SouadHadjiat removed their assignment May 24, 2024
Goumies added a commit that referenced this issue May 31, 2024
@Goumies
[frontend/backend] [WIP] Display Markings filed on user choice config…
e90f8da 
…uration only (#6149)
Goumies added a commit that referenced this issue Jun 4, 2024
@Goumies
[frontend/backend] Display Markings filed on user choice configuratio…
5778a3f 
…n only (#6149)
Goumies added a commit that referenced this issue Jun 4, 2024
@Goumies
[frontend/backend] Display Markings filed on user choice configuratio…
b5defa5 
…n only (#6149)
Goumies added a commit that referenced this issue Jun 6, 2024
@Goumies
[frontend/backend] Display Markings filed on user choice configuratio…
d3cdb51 
…n only (#6149)

[frontend/backend] Display Markings filed on user choice configuration only (#6149)
Goumies added a commit that referenced this issue Jun 6, 2024
@Goumies
[frontend/backend] Add markings field to CSV feed ingester creation (#…
987ff92 
…6149)
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend/backend] Display Markings filed on user choice configuratio…
f2ad885 
…n only (#6149)

[frontend/backend] Display Markings filed on user choice configuration only (#6149)
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend/backend] Add markings field to CSV feed ingester creation (#…
b3754c8 
…6149)
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend] Resolve user choice setting (#6149)
1c01a73
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[backend] Rollback has_user_choice add (#6149)
d5803c4
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend] Fix object marking typing (#6149)
e69b804
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend] Rollback has_user_choice remaining (#6149)
1f5252b
Goumies added a commit that referenced this issue Jun 7, 2024
@Goumies
[frontend] Lint (#6149)
d848001
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Create CSV Ingestion with default choice CSV mapper config (…
3c5929a 
…#6149)
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Edit CSV Ingestion with default choice CSV mapper config (#…
498298c 
…6149)
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Fix import (#6149)
6daa3b2
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Lint (#6149)
440b89b
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Align with CSV import behaviour (#6149)
1a90e88
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Add sufficient null check (#6149)
08bf2ed
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Fix unused param (#6149)
52d914a
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend/backend] Fix behaviour (#6149)
952a03b
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend] Fix typing (#6149)
02361c3
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend] Fix marking definition with solid typing (#6149)
851e8bb
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend] Fix marking definition with solid typing (#6149)
5fbe8e8
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Add marking definition to CSV feed ingestion test (#6149)
1bfd348
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Rearrange forms for clarification (#6149)
d4e97e0
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] List data creator's allowed markings (#6149)
af60039
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend] Fetch data with ingestion user (#6149)
f091c51
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Rollback title change (#6149)
c77233f
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Add alert box to the explicit CSV mapper selection impact (#…
4e38dc1 
…6149)
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend] Sort other user's markings (#6149)
cb679a6
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend] Improve performance with single refEntities fetching (#6149)
a66e331
Goumies added a commit that referenced this issue Jun 26, 2024
@Goumies
[backend/frontend] Process review (#6149)
d0ece65
Kedae pushed a commit that referenced this issue Jun 26, 2024
@Goumies
[frontend/backend] In CSV Feed Ingester, take into account Default Ma…
36e0eec 
…rking definition options from CSV Mapper (#6149)
@Kedae Kedae added the solved use to identify issue that has been solved (must be linked to the solving PR) label Jun 26, 2024
dotdev8 pushed a commit to fbicyber/opencti__opencti that referenced this issue Jun 26, 2024
@Goumies @dotdev8
[frontend/backend] In CSV Feed Ingester, take into account Default Ma…
3d88874 
…rking definition options from CSV Mapper (OpenCTI-Platform#6149)
Goumies added a commit that referenced this issue Jun 27, 2024
@Goumies
[backend] Allow ingestion user to test CSV mapper (#6149)
c482bdd
Goumies added a commit that referenced this issue Jun 27, 2024
@Goumies
[frontend] Improve configuration error message (#6149)
dd8cdac
@Goumies Goumies mentioned this issue Jun 27, 2024
Merged
5 tasks
Kedae pushed a commit that referenced this issue Jun 27, 2024
@Goumies
[Frontend] CSV Mapper & Ingester improvements (#6149)
bf16268
@Jipegien Jipegien added the ingestion Linked to ingestion (manual, from file, feeds & queue) label Jul 1, 2024
dotdev8 pushed a commit to fbicyber/opencti__opencti that referenced this issue Jul 8, 2024
@Goumies @dotdev8
[Frontend] CSV Mapper & Ingester improvements (OpenCTI-Platform#6149)
a6d9c1d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Goumies Goumies

@Jipegien Jipegien

Labels
feature use for describing a new feature to develop ingestion Linked to ingestion (manual, from file, feeds & queue) solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.2.0
5 participants
@SouadHadjiat @SamuelHassine @Goumies @Kedae @Jipegien