Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bulk deletion with the "select all" button deletes entities it shouldn't #6268

Closed
Lhorus6 opened this issue Mar 4, 2024 · 2 comments · Fixed by #6269
Closed

Bulk deletion with the "select all" button deletes entities it shouldn't #6268

Lhorus6 opened this issue Mar 4, 2024 · 2 comments · Fixed by #6269
Assignees
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filters temporarily used to identify filter issue to facilitate filter team’s work identification solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone

Comments

@Lhorus6
Copy link

Lhorus6 commented Mar 4, 2024

Description

When I delete entities in a report using the "select all" button, an unexpected behavior occurs: the selected entities are not deleted, but others are.

Environment

OCTI 6.0.4

Reproducible Steps

Steps to create the smallest reproducible scenario:

  1. Create a report
  2. Go to the "entities" tab
  3. Add a country to it
  4. Add incidents
  5. Filter on the left to see only incidents
  6. Select all
  7. Delete entities
    -> Incidents are not deleted, but countries are.
@Lhorus6 Lhorus6 added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 4, 2024
@Jipegien Jipegien added critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Mar 4, 2024
@Jipegien Jipegien added this to the Release 6.0.5 milestone Mar 4, 2024
@Jipegien Jipegien assigned Jipegien and jpkha and unassigned Jipegien Mar 4, 2024
@Lhorus6
Copy link
Author

Lhorus6 commented Mar 4, 2024

It seems that the filter set on the right-hand banner is not taken into account when selecting all, because if you have a City, an Indicator and an Intrusion set and you filter on one of the three to delete it, it deletes everything.

A strange thing is that if you have Incidents, these are never deleted.

@Archidoit Archidoit self-assigned this Mar 4, 2024
@Archidoit Archidoit added the filters temporarily used to identify filter issue to facilitate filter team’s work identification label Mar 4, 2024
@Archidoit
Copy link
Member

Other bug : in the right bar of Indicators, we can't select more than 1 pattern type or more than 1 observable type

Archidoit added a commit that referenced this issue Mar 4, 2024
Kedae added a commit that referenced this issue Mar 4, 2024
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
@Kedae Kedae added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 4, 2024
Archidoit added a commit that referenced this issue Mar 7, 2024
Archidoit added a commit that referenced this issue Mar 7, 2024
Archidoit added a commit that referenced this issue Mar 11, 2024
Goumies pushed a commit that referenced this issue Mar 13, 2024
Co-authored-by: Adrien Servel <adrien.servel@filigran.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP filters temporarily used to identify filter issue to facilitate filter team’s work identification solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants