Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When upserting an entity, name should also change #6315

Closed
2 tasks
SamuelHassine opened this issue Mar 12, 2024 · 1 comment
Closed
2 tasks

When upserting an entity, name should also change #6315

SamuelHassine opened this issue Mar 12, 2024 · 1 comment
Assignees
@SamuelHassine
Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Milestone
Release 6.0.6

Comments

@SamuelHassine
Copy link
Member

SamuelHassine commented Mar 12, 2024 •
edited by richard-julien

Description

  1. Create an entity named "A" confidence = 75
  2. Add alias "B" to entity A
  3. Try to create the entity named "B" confidence = 75

Current result: Nothing
Expected result: Entity A is now named B and A is put in alias of B

This was the previous behavior and it is critical for data health.

  • Bug fixed
  • Integration test coded
@SamuelHassine SamuelHassine added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team critical use to identify critical bug to fix ASAP and removed needs triage use to identify issue needing triage from Filigran Product team labels Mar 12, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.6 milestone Mar 12, 2024
@jpkha jpkha self-assigned this Mar 12, 2024
@jpkha
Copy link
Member

jpkha commented Mar 12, 2024 •
edited

@SamuelHassine The issue come from this code :
https://github.com/OpenCTI-Platform/opencti/blob/beaac8fe6952d9517783a19eb3487e6930c61f05/opencti-platform/opencti-graphql/src/database/middleware.js#L1387C1-L1395C3

It was added by this commit :
8733303

What would you like to do ?
@SamuelHassine @richard-julien

@SamuelHassine SamuelHassine assigned SamuelHassine and unassigned jpkha Mar 12, 2024
SamuelHassine added a commit that referenced this issue Mar 12, 2024
@SamuelHassine
[backend] Fix name update in upsert on same confidence (#6315)
6101d43
@SamuelHassine SamuelHassine added the solved use to identify issue that has been solved (must be linked to the solving PR) label Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SamuelHassine SamuelHassine

Labels
bug use for describing something not working as expected critical use to identify critical bug to fix ASAP solved use to identify issue that has been solved (must be linked to the solving PR)
Projects
None yet
Milestone
Release 6.0.6
Development

No branches or pull requests
2 participants
@SamuelHassine @jpkha