Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[technical] wrong extension typing in StixCyberObject #6409

Open
labo-flg opened this issue Mar 21, 2024 · 1 comment
Open

[technical] wrong extension typing in StixCyberObject #6409

labo-flg opened this issue Mar 21, 2024 · 1 comment
Assignees
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Milestone

Comments

@labo-flg
Copy link
Member

Related to PR #6402

We found out that SCO might not have an extension STIX_EXT_OCTI_SCO once converted to stix. This caused issue in playbook, solved with proper checks.

Root issue is not addressed : we need to properly type StixCyberObject so that this extension can be undefined.
Obviously this lead to a bunch of errors to handle, mostly in stix-converter.ts.

We've reviewed the work to do and it's not a trivial task taht could be done on the same PR.
We need to rework how the utility functions buildStixCyberObservable and cleanObject work together.

With proper typing, we will implement proper checking everywhere (at leats in TS files) it's used and we'll probably save us some bugs in the future !

@labo-flg labo-flg added bug use for describing something not working as expected needs triage use to identify issue needing triage from Filigran Product team labels Mar 21, 2024
@SamuelHassine SamuelHassine added this to the Release 6.0.8 milestone Mar 22, 2024
@nino-filigran
Copy link

@SouadHadjiat & @labo-flg I remove the needs triage here even though I cannot reproduce, since I know the original bug. I'm not able to reproduce due to my limited competences in development but trust you there.

@nino-filigran nino-filigran removed the needs triage use to identify issue needing triage from Filigran Product team label Mar 22, 2024
@Kedae Kedae modified the milestones: Release 6.0.8, Release 6.0.9 Mar 22, 2024
@SamuelHassine SamuelHassine modified the milestones: Release 6.0.9, Release 6.0.10, Release 6.1.0 Apr 3, 2024
@labo-flg labo-flg added the technical improvement Technical refactor or improvement is needed label May 6, 2024
@Kedae Kedae modified the milestones: Bugs backlog, Release 6.2.0 May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug use for describing something not working as expected technical improvement Technical refactor or improvement is needed
Projects
None yet
Development

No branches or pull requests

5 participants