[technical] wrong extension typing in StixCyberObject #6409
Labels
bug
use for describing something not working as expected
technical improvement
Technical refactor or improvement is needed
Milestone
Related to PR #6402
We found out that SCO might not have an extension
STIX_EXT_OCTI_SCO
once converted to stix. This caused issue in playbook, solved with proper checks.Root issue is not addressed : we need to properly type
StixCyberObject
so that this extension can be undefined.Obviously this lead to a bunch of errors to handle, mostly in
stix-converter.ts
.We've reviewed the work to do and it's not a trivial task taht could be done on the same PR.
We need to rework how the utility functions
buildStixCyberObservable
andcleanObject
work together.With proper typing, we will implement proper checking everywhere (at leats in TS files) it's used and we'll probably save us some bugs in the future !
The text was updated successfully, but these errors were encountered: