Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend] Fix Promote observable component crashes (#6399) #6402

Merged
merged 1 commit into from Mar 21, 2024

Conversation

SouadHadjiat
Copy link
Member

@SouadHadjiat SouadHadjiat commented Mar 21, 2024

Proposed changes

  • handle case where observable.extensions[STIX_EXT_OCTI_SCO] is undefined

Related issues

To reproduce the issue, you need to create an observable (reproduced with ipv4) without description nor score. then follow the steps described in the issue.

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat linked an issue Mar 21, 2024 that may be closed by this pull request
@SouadHadjiat SouadHadjiat added the filigran team use to identify PR from the Filigran team label Mar 21, 2024
@SouadHadjiat SouadHadjiat marked this pull request as ready for review March 21, 2024 11:09
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 67.26%. Comparing base (1e90cee) to head (2d3ade3).

Files Patch % Lines
...raphql/src/modules/playbook/playbook-components.ts 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6402   +/-   ##
=======================================
  Coverage   67.26%   67.26%           
=======================================
  Files         541      541           
  Lines       65075    65075           
  Branches     5397     5398    +1     
=======================================
+ Hits        43770    43772    +2     
+ Misses      21305    21303    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@labo-flg labo-flg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok, but we need to rework the typescript and related stix converters. This can hide bugs.

@SouadHadjiat SouadHadjiat merged commit 4cd8e99 into master Mar 21, 2024
8 checks passed
@SouadHadjiat SouadHadjiat deleted the issue/6399 branch March 21, 2024 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
filigran team use to identify PR from the Filigran team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Playbook] "Promote observable" component crashes
2 participants